V3#26
Merged
Merged
Conversation
The 'skips interface entries with no addresses' spec patched networkInterfaces on the CommonJS os object, which the module-mocked ESM binding never reads — the test passed against the real interfaces (false positive) and the undefined-entry guard in UDPWorker.selectNetworkInterface() stayed uncovered. The os mock now routes networkInterfaces through a mutable holder (networkInterfacesMock.impl) that tests swap at call time, so the mocked binding observes the fixture. Line coverage: 2567/2567 (100%).
The default import of a builtin module is the same live, mutable CommonJS module object require() returns (unlike an import-namespace, which is frozen), so the util.inspect patching keeps working and the emitted spec no longer needs a createRequire shim.
- package-lock.json: record the engines requirement (node >=22.12.0) introduced by the ESM migration - copyEventEmitter spec: drop redundant explanatory comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.